Fix latent kwarg bug in PreprocessedMetadataPbWrapper LocalUri branch#639
Queued
kmontemayor2-sc wants to merge 3 commits into
Queued
Fix latent kwarg bug in PreprocessedMetadataPbWrapper LocalUri branch#639kmontemayor2-sc wants to merge 3 commits into
kmontemayor2-sc wants to merge 3 commits into
Conversation
LocalFsUtils.list_at_path's keyword-only parameter was renamed from `entity` to `file_system_entity`, but the partial in PreprocessedMetadataPbWrapper.__get_feature_to_vocab_list_map still forwarded the old name. functools.partial doesn't validate kwargs at construction time, so the TypeError was latent — every production caller hits the GcsUri branch, and no test exercised the LocalUri branch. Add a unit test that constructs the wrapper with a LocalUri transform_fn_assets_uri to lock in the kwarg name. Also fix the stale `entity` reference in list_at_path's docstring. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
/all_test |
Contributor
GiGL Automation@ 17:14:15UTC : 🔄 @ 17:24:11UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:14:16UTC : 🔄 @ 18:46:43UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:14:18UTC : 🔄 @ 17:17:51UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:14:20UTC : 🔄 @ 18:33:14UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:14:20UTC : 🔄 @ 17:27:03UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 17:14:23UTC : 🔄 @ 18:16:03UTC : ✅ Workflow completed successfully. |
yliu2-sc
approved these changes
May 13, 2026
Three markers no longer suppress any mypy errors: the partial() call, the lambda assignment in the LocalUri branch, and the call site of list_files_fn. The two on the GcsUri-branch assignments are still load-bearing — assigning a Callable[[GcsUri], …] to a name previously bound to a Callable[[LocalUri], …] is a real type incompatibility. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mkolodner-sc
approved these changes
May 14, 2026
kmontemayor2-sc
requested review from
nshah-sc,
svij-sc,
xgao4-sc and
zfan3-sc
as code owners
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalFsUtils.list_at_path's keyword-only parameter was renamed from
entitytofile_system_entity, but the partial in PreprocessedMetadataPbWrapper.__get_feature_to_vocab_list_map still forwarded the old name. functools.partial doesn't validate kwargs at construction time, so the TypeError was latent — every production caller hits the GcsUri branch, and no test exercised the LocalUri branch. Add a unit test that constructs the wrapper with a LocalUri transform_fn_assets_uri to lock in the kwarg name. Also fix the staleentityreference in list_at_path's docstring.Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO